From: kfraser@localhost.localdomain <kfraser@localhost.localdomain>
Date: Fri, 7 Sep 2007 09:26:33 +0000 (+0100)
Subject: Fix xenstored's dup2() usage.
X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~14987^2~6
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/success//%22http:/www.example.com/cgi/success/?a=commitdiff_plain;h=038aa6bdc09e895a5a09e52e3710572a27978dd8;p=xen.git

Fix xenstored's dup2() usage.

The dup2() calls had their arguments reversed. Also remove the
unnecessary close() calls.

Signed-off-by: John Levon <john.levon@sun.com>
---

diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c
index e68004ad05..1b9b32d67d 100644
--- a/tools/xenstore/xenstored_core.c
+++ b/tools/xenstore/xenstored_core.c
@@ -1878,14 +1878,14 @@ int main(int argc, char *argv[])
 		fflush(stdout);
 	}
 
-	/* close stdin/stdout now we're ready to accept connections */
+	/* redirect to /dev/null now we're ready to accept connections */
 	if (dofork) {
 		int devnull = open("/dev/null", O_RDWR);
 		if (devnull == -1)
 			barf_perror("Could not open /dev/null\n");
-		close(STDIN_FILENO);  dup2(STDIN_FILENO, devnull);
-		close(STDOUT_FILENO); dup2(STDOUT_FILENO, devnull);
-		close(STDERR_FILENO); dup2(STDERR_FILENO, devnull);
+		dup2(devnull, STDIN_FILENO);
+		dup2(devnull, STDOUT_FILENO);
+		dup2(devnull, STDERR_FILENO);
 		close(devnull);
 		xprintf = trace;
 	}